Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Upgrade raft-engine dependency cascading #3305

Merged
merged 8 commits into from
Feb 18, 2024

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Feb 17, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added docs-not-required This change does not impact docs. size/xs labels Feb 17, 2024
Cargo.lock Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Collaborator Author

tisonkun commented Feb 17, 2024

ICE. Convert to draft -

error: internal compiler error: compiler/rustc_codegen_llvm/src/debuginfo/metadata.rs:473:14: debuginfo: unexpected type in type_di_node(): CoroutineClosure(DefId(0:8575 ~ common_meta[30e1]::state_store::tests::test_meta_state_store#1::{closure#0}::{closure#0}), [i8, Binder(extern "RustCall" fn(std::future::ResumeTy, (&ReBound(DebruijnIndex(0), BoundRegion { var: 0, kind: BrAnon }) str,)) -> ((), std::vec::Vec<(std::string::String, std::vec::Vec<u8, std::alloc::Global>), std::alloc::Global>), [Region(BrAnon)]), (&ReErased state_store::KvStateStore,), Binder(fn() -> (&ReBound(DebruijnIndex(0), BoundRegion { var: 0, kind: BrAnon }) state_store::KvStateStore,), [Region(BrAnon)]), CoroutineWitness(DefId(0:8576 ~ common_meta[30e1]::state_store::tests::test_meta_state_store#1::{closure#0}::{closure#0}::{closure#0}), [])])

@tisonkun tisonkun marked this pull request as draft February 17, 2024 18:13
@tisonkun
Copy link
Collaborator Author

Let me try to narrow the change scope.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun marked this pull request as ready for review February 17, 2024 18:18
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9ce270) 85.52% compared to head (0c142cd) 85.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3305      +/-   ##
==========================================
- Coverage   85.52%   85.09%   -0.43%     
==========================================
  Files         872      872              
  Lines      141944   141944              
==========================================
- Hits       121395   120787     -608     
- Misses      20549    21157     +608     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag enabled auto-merge February 18, 2024 02:16
@evenyag evenyag added this pull request to the merge queue Feb 18, 2024
Merged via the queue into GreptimeTeam:main with commit b889d57 Feb 18, 2024
34 checks passed
@tisonkun tisonkun deleted the upgrade-raft-engine-dep branch May 3, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[smartstring 1.0.1] error[E0433]: failed to resolve: use of undeclared crate or module alloc
3 participants