fix[next]: remove indeterminism in closure_var extraction #2476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort closure variables for deterministic results. Problem only surfaced on beverin.
tehrengruber
approved these changes
Feb 6, 2026
Contributor
tehrengruber
left a comment
tehrengruber
left a comment
There was a problem hiding this comment.
Good to go if you agree with my suggestion.
| return {**builtins, **globals, **nonlocals} # nonlocals override globals | ||
|
|
||
| # nonlocals override globals, sorted for deterministic results | ||
| return dict(sorted({**builtins, **globals, **nonlocals}.items())) |
Contributor
There was a problem hiding this comment.
Suggested change
| return dict(sorted({**builtins, **globals, **nonlocals}.items())) | |
| return dict(sorted({**builtins, **globals, **nonlocals}.items(), key=lambda v: v[0])) |
Otherwise it's also doing __lte__ on the values right? I'm surprised this works.
Contributor
Author
There was a problem hiding this comment.
No, it doesn't compare the second element of the tuple (values) unless the first (keys) are equal.
Contributor
Author
There was a problem hiding this comment.
So not sure if my version is considered canonical @egparedes
Contributor
There was a problem hiding this comment.
Ah and since they are unique it only considers the first one. I'd still use the key for clarity, but both fine with me.
Contributor
There was a problem hiding this comment.
I think @havogt is the standard one, since we are sure that all keys are different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort closure variables for deterministic results. The effect was FunctionDefinitions were in non-deterministic order in itir.Program.
This problem only surfaced on beverin.