Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[defect] Fix list pages not auto-refreshing after delete AND list icon buttons #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicksinishtaj
Copy link
Contributor

Moving content from GenericListItem into ListPage

@nicksinishtaj nicksinishtaj added bug Something isn't working Generic UI For generic UI components labels Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #116 (d6878c1) into main (1c62a35) will decrease coverage by 16.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #116       +/-   ##
===========================================
- Coverage   32.85%   16.50%   -16.35%     
===========================================
  Files         110       39       -71     
  Lines        4121      733     -3388     
  Branches      190      132       -58     
===========================================
- Hits         1354      121     -1233     
+ Misses       2766      611     -2155     
  Partials        1        1               
Flag Coverage Δ
functions ?
unittests 16.50% <0.00%> (-16.35%) ⬇️
webapp 16.50% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
webapp/src/components/misc/GenericListItem.tsx 0.00% <ø> (-5.27%) ⬇️
webapp/src/components/pages/ListPage.tsx 3.57% <0.00%> (-1.99%) ⬇️
functions/src/systems/uas/permissionSwitch.ts
...tions/src/modules/pm/categories/prizes/getPrize.ts
functions/src/modules/mewm/events/listEvents.ts
functions/src/modules/stpm/tiers/updateTier.ts
...ctions/src/modules/stpm/companies/updateCompany.ts
functions/src/modules/mewm/index.ts
...unctions/src/modules/mewm/timeslots/getTimeslot.ts
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c62a35...d6878c1. Read the comment docs.

@nicksinishtaj nicksinishtaj changed the title [defect] Fix list pages not auto-refreshing after delete [defect] Fix list pages not auto-refreshing after delete AND list icon buttons Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Generic UI For generic UI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant