Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROUP-89 Update Parsing Logic #20

Merged
merged 5 commits into from
Mar 1, 2024
Merged

GROUP-89 Update Parsing Logic #20

merged 5 commits into from
Mar 1, 2024

Conversation

makmn1
Copy link
Member

@makmn1 makmn1 commented Mar 1, 2024

Description of Changes

Not a bug, but an issue blocking GROUP-89 for Group Sync. Currently, we have this behavior:

  1. Server sends an event to a client. The event is serialized, but it also has a nested object which is already serialized, so that ends up being serialized again as a string the second time
  2. The client deserializes the event object, but it also deserializes the event data

When making a change in Group Sync to not have the nested event data already serialized, this breaks compatibility with GroupHQ clients since they expect to parse a string. To ensure compatibility with the new changes, as well as backwards compatibility with the old changes (which is needed until Group Sync instances are updated), parsing is now done only if the nested event data is a string. If not, then it should already be deserialized to an object.

Additional Info

This pull request also includes updates to dependencies, which is probably why there is a +5000 -5000 code change count. Probably should put updates in a separate pull request in the future.

@makmn1 makmn1 added the enhancement New feature or request label Mar 1, 2024
@makmn1 makmn1 self-assigned this Mar 1, 2024
@makmn1 makmn1 changed the title Group 89 fix loading issues GROUP-89 Update Parsing Logic Mar 1, 2024
@makmn1 makmn1 merged commit 2acef68 into main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant