Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Task Categorization and Priority Tagging #61

Closed
wants to merge 0 commits into from

Conversation

SSShogunn
Copy link
Contributor

Description

This feature allows users to categorize their tasks and assign priority levels, enhancing the organization and focus on important tasks.

Fixes #52

Type of change

-New fields were added to the task input form to allow users to select a category and priority level for each task.
-The structure of the todoList was updated to include the new fields for category and priority. Each task now contains properties for name, date, time, category, and priority.
-The display of tasks was updated to show the assigned category and priority levels alongside the task name, date, and time.
-Sorting functionality was implemented to allow users to sort tasks based on category and priority. This includes toggling between ascending and descending order for both sorting options.

  • [✔️] New feature (non-breaking change)
  • [❌] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [❌] This change requires a documentation update

How Has This Been Tested?

Recording.2024-10-12.122722.mp4

Checklist:

  • [✔️] My code follows the style guidelines of this project
  • [✔️] I have performed a self-review of my code
  • [✔️] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [✔️] My changes generate no new warnings
  • [✔️] Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

@SSShogunn the checks are failing try to find out using npm run lint.

@SSShogunn
Copy link
Contributor Author

SSShogunn commented Oct 12, 2024

to-do-list@1.0.0 lint
eslint .

D:\Contributions\To-Do-List\script.js
42:10 error 'deleteTodo' is defined but never used no-unused-vars
49:10 error 'editTodo' is defined but never used no-unused-vars
174:10 error 'sortTodos' is defined but never used no-unused-vars

✖ 3 problems (3 errors, 0 warnings)

these functions are being used in the script.js in the updateTodoList() function, i will try to fix this using the addEventListener

@Anshgrover23
Copy link
Collaborator

@SSShogunn Please find a workaround for this. and please also run npm run format

@Anshgrover23
Copy link
Collaborator

Anshgrover23 commented Oct 12, 2024

@SSShogunn Nice work 👍, but there are few errors
image
when we try to update todo item then we are unable to do so and we get alert two times
see the video also for reference :

freecompress-Todo-List.and.1.more.page.-.Personal.-.Microsoft_.Edge.2024-10-12.13-48-14.mp4

@SSShogunn
Copy link
Contributor Author

SSShogunn commented Oct 12, 2024

i made the changes in the fix_branch in my repository, but the main in getting updated.
can i create a complete new pull request ?? @Anshgrover23

@divanshu-go
Copy link
Contributor

@SSShogunn feel free to open a new PR and ping us when its ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Task Categorization and Priority Tagging
3 participants