Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the lint errors #66

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Resolved the lint errors #66

merged 2 commits into from
Oct 12, 2024

Conversation

Nun-Thee-Knee
Copy link
Contributor

@Nun-Thee-Knee Nun-Thee-Knee commented Oct 12, 2024

Description

When the command npm run lint was executed the following error was coming
31:10 error 'deleteTodo' is defined but never used no-unused-vars
38:10 error 'editTodo' is defined but never used no-unused-vars

✖ 2 problems (2 errors, 0 warnings)

PROBLEM
The eslint does not recognize the usage of variable if it is used in the onClick as a function.

SOLUTION
Added an event listener instead of onClick method which will do the job for deleteTodo and editTodo options

Fixes #58

Type of change

Instead of using onClick approach now the buttons are using the addEventListener

Please delete options that are not relevant.

  • Bug fix (non-breaking change)

How Has This Been Tested?

After making the changes I have tried running 'npm run lint'. The errors which I was facing is now gone.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Anshgrover23
Copy link
Collaborator

freecompress-Todo-List.and.3.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-12.13-07-06.mp4

@@Nun-Thee-Knee nice work. but your logic is breaking the app's logic check in above video.

@Nun-Thee-Knee
Copy link
Contributor Author

freecompress-Todo-List.and.3.more.pages.-.Personal.-.Microsoft_.Edge.2024-10-12.13-07-06.mp4
@@Nun-Thee-Knee nice work. but your logic is breaking the app's logic check in above video.

Sir, I have recently made some changes. Can you review the code and let me know?

@Anshgrover23
Copy link
Collaborator

@Nun-Thee-Knee Nice work!. Don't forget to star the repository.

@Anshgrover23 Anshgrover23 merged commit e3a82a2 into Groverio:main Oct 12, 2024
2 checks passed
@divanshu-go divanshu-go mentioned this pull request Oct 12, 2024
1 task
@Nun-Thee-Knee
Copy link
Contributor Author

@Nun-Thee-Knee Nice work!. Don't forget to star the repository.

Thank You Sir!
I will star the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LINT] resolve lint errors
2 participants