destinations

pkg/resources/destinations.go

@@ -3,6 +3,7 @@ package resources
 import (
 	"context"
 	"fmt"
+	"strconv"
 
 	"github.com/gthesheep/terraform-provider-segment/pkg/segment"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -42,7 +43,7 @@ func ResourceDestination() *schema.Resource {
 			"settings": &schema.Schema{
 				Type:        schema.TypeMap,
 				Required:    true,
-				Description: "Map containing settings for the destination",
+				Description: "Map containing settings for the destination, currently all values must be provided as strings",
 				Elem: &schema.Schema{
 					Type: schema.TypeString,
 				},
@@ -98,6 +99,14 @@ func resourceDestinationRead(ctx context.Context, d *schema.ResourceData, m inte
 	if err := d.Set("destination_slug", destination.Metadata.Slug); err != nil {
 		return diag.FromErr(err)
 	}
+	if err := d.Set("source_id", destination.SourceID); err != nil {
+		return diag.FromErr(err)
+	}
+	for k, v := range destination.Settings {
+		if _, ok := v.(bool); ok {
+			destination.Settings[k] = strconv.FormatBool(v.(bool))
+		}
+	}
 	if err := d.Set("settings", destination.Settings); err != nil {
 		return diag.FromErr(err)
 	}

pkg/resources/destinations_acceptance_test.go

@@ -67,6 +67,9 @@ resource "segment_destination" "test_destination" {
   settings = {
     containerId = "xxxx"
     environment = "gtm_auth=xxxx"
+    trackAllPages = "false"
+    trackCategorizedPages = "false"
+    trackNamedPages = "false"
   }
 }
 `, sourceSlug, sourceName, name, destinationSlug)

pkg/segment/destinations.go

@@ -20,7 +20,7 @@ type DestinationMetadata struct {
 type Destination struct {
 	ID       *string                `json:"id,omitempty"`
 	Name     string                 `json:"name"`
-	Metadata SourceMetadata         `json:"metadata"`
+	Metadata DestinationMetadata    `json:"metadata"`
 	Enabled  bool                   `json:"enabled"`
 	SourceID string                 `json:"sourceId"`
 	Settings map[string]interface{} `json:"settings"`