Solve naming issue in loader functions#75
Merged
leoguignard merged 1 commit intov2.xfrom Jun 16, 2025
Merged
Conversation
leoguignard
approved these changes
Jun 16, 2025
Member
leoguignard
left a comment
leoguignard
left a comment
There was a problem hiding this comment.
All good, thanks for the catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some loading functions (namely
read_from_csvandread_from_tgmm_xml) use the variableposto store both the dictionary of all node positions and individual positions, which leads to codebreaking errors. This PR introduces alternative variables that are coherent with other functions.