Skip to content

Loading different attributes #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leoguignard merged 6 commits into from
Jun 25, 2025
Merged

Loading different attributes #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c212ad1
bump version 2.1.0 -> 2.1.1
BadPrograms Jun 16, 2025
ad0222f
fix time_Resolution
BadPrograms Jun 22, 2025
af58d28
fixed the _time for remove_nodes
BadPrograms Jun 23, 2025
4a0fba1
Revert "bump version 2.1.0 -> 2.1.1"
BadPrograms Jun 24, 2025
f1867e7
bump version 2.1.1 -> 2.2.0
BadPrograms Jun 24, 2025
78174b4
bump version 2.0.1 -> 2.0.2
BadPrograms Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ maintainers = [
]
name = "LineageTree"
description = "Structure for Lineage Trees"
version = "2.0.1"
version = "2.0.2"
license = "MIT"
license-files = [ "LICENSE" ]
readme = {file = "README.md", content-type = "text/markdown"}
Expand Down Expand Up @@ -76,7 +76,7 @@ profile = "black"
line_length = 79

[tool.bumpver]
current_version = "2.0.1"
current_version = "2.0.2"
version_pattern = "MAJOR.MINOR.PATCH[-TAG]"
commit_message = "bump version {old_version} -> {new_version}"
commit = true
Expand Down
2 changes: 1 addition & 1 deletion src/LineageTree/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
__version__ = "2.0.1"
__version__ = "2.0.2"
from .lineageTree import lineageTree
from .lineageTreeManager import lineageTreeManager
from .loaders import (
Expand Down
3 changes: 1 addition & 2 deletions src/LineageTree/lineageTree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ def remove_nodes(self, group: int | set | list) -> None:
"predecessor",
"_successor",
"_predecessor",
"_time",
]:
attr_value.pop(node, ())
if self._predecessor.get(node):
Expand Down Expand Up @@ -1001,7 +1000,7 @@ def load(clf, fname: str):
properties = {
prop_name: prop
for prop_name, prop in lT.__dict__.items()
if isinstance(prop, dict)
if (isinstance(prop, dict) or prop_name == "_time_resolution")
Copy link
Member

@leoguignard leoguignard Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we think of possible other properties?
Probably there is no strong reason for only allowing dictionary properties.

That being said, we only want lineage Tree properties and not other "weird" things/dunder properties and so on.

Copy link
Collaborator Author

@BadPrograms BadPrograms Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for older files only v1.x, so I don't think we should overthink that. There is only one property we used in this version: time_resolution.

Copy link
Member

@leoguignard leoguignard Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, it is marginally impacting anyway ...

and prop_name
not in [
"successor",
Expand Down
Loading