Uniform leaf node positioning on lineage graph#86
Merged
leoguignard merged 7 commits intov3.xfrom Aug 27, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.x #86 +/- ##
==========================================
+ Coverage 86.00% 86.20% +0.20%
==========================================
Files 20 20
Lines 1765 1791 +26
==========================================
+ Hits 1518 1544 +26
Misses 247 247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoguignard
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the function that positions nodes on the 2D lineage graph so that leaf nodes are uniformly positioned along the horizontal axis, i.e the horizontal gap between two consecutive leaf nodes on the lineage graph is a constant across all pairs of consecutive leaf nodes.
This has the effect of optimizing the space spanned by the lineage graph, so that lineages with many divisions are not squished by "shallow" lineages. The idea is illustrated on the following image:
