Skip to content

Comments

Uniform leaf node positioning on lineage graph#86

Merged
leoguignard merged 7 commits intov3.xfrom
uniform_tree
Aug 27, 2025
Merged

Uniform leaf node positioning on lineage graph#86
leoguignard merged 7 commits intov3.xfrom
uniform_tree

Conversation

@jules-vanaret
Copy link
Contributor

This PR modifies the function that positions nodes on the 2D lineage graph so that leaf nodes are uniformly positioned along the horizontal axis, i.e the horizontal gap between two consecutive leaf nodes on the lineage graph is a constant across all pairs of consecutive leaf nodes.

This has the effect of optimizing the space spanned by the lineage graph, so that lineages with many divisions are not squished by "shallow" lineages. The idea is illustrated on the following image:
pr_uniform_tree

@jules-vanaret jules-vanaret changed the title Uniform tree Uniform leaf node positioning on lineage graph Aug 26, 2025
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.20%. Comparing base (f835b62) to head (366d0e0).
⚠️ Report is 8 commits behind head on v3.x.

Additional details and impacted files
@@            Coverage Diff             @@
##             v3.x      #86      +/-   ##
==========================================
+ Coverage   86.00%   86.20%   +0.20%     
==========================================
  Files          20       20              
  Lines        1765     1791      +26     
==========================================
+ Hits         1518     1544      +26     
  Misses        247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leoguignard leoguignard merged commit 7f065c8 into v3.x Aug 27, 2025
3 checks passed
@leoguignard leoguignard deleted the uniform_tree branch August 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants