Add docker and solution to vectorfield error#7
Add docker and solution to vectorfield error#7gatocor wants to merge 5 commits intoGuignardLab:masterfrom
Conversation
leoguignard
left a comment
There was a problem hiding this comment.
Small question about the number of dependencies. Otherwise all good. Thanks a lot!!
There was a problem hiding this comment.
Not that it's necessary wrong but it looks like a very long list of dependencies like for example is networkx really necessary?
But anyway, since it's already built it does not matter too much.
There was a problem hiding this comment.
This is just because skimage is installed.
I added some aditional basic packages to help visualizing the results and working around with the data (matplotlib, scikitimage), an those installed all the rest (networkx for example is a installed by scikitimage)
With the docker is the same, I even installed SimpleITK to rich set os tools without having to install anything else.
Do you think a more minimalistec version with just registrationtools will be better?
There was a problem hiding this comment.
Hi, yes I think that if there is no direct use of a library it's better to leave it out.
That being said, I am not super familiar with docker builds and I might be wrong
There was a problem hiding this comment.
Same comment as for the other dependencies file
This pull provides solutions to three aspets:
requirements.ymlin the main folder so everything can be installed in a more straightforward way with conda.