Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subparser class attributes #55

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Subparser class attributes #55

merged 2 commits into from
Jul 23, 2024

Conversation

venaturum
Copy link
Member

@venaturum venaturum commented Jul 18, 2024 •
edited
Loading

Checklist

  • tests passed
  • all linting tests pass

Description:

Slight rework of internals to make subclassing simpler

@venaturum venaturum requested a review from simonbowly July 18, 2024 13:55
@venaturum
Copy link
Member Author

To make this a bit clearer, there's only one relevant change:
src/gurobi_logtools/parsers/single_log.py

@venaturum venaturum requested review from mattmilten and removed request for simonbowly July 22, 2024 13:59
@mattmilten mattmilten merged commit 1be6a99 into Gurobi:master Jul 23, 2024
6 checks passed
@simonbowly
Copy link
Member

Thanks Matthias - sorry I didn't get to this Riley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmilten mattmilten mattmilten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@venaturum @simonbowly @mattmilten