fix(network): the process exiting without exit code #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exiting in deadlock When I integrate with NestJS, I could create GET requests but POST requests returned null in response because the NodeJS exits when it could not wait an promise. This bug was caused by request.ts when I override the internal variable of stream _readableState, with this, the NestJS could not process the request and the process exits after some seconds without exit code.
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 710 709 -1
Branches 171 171
=========================================
- Hits 710 709 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I integrate with NestJS, I could create GET requests but POST requests returned null in
response because the NodeJS exits when it could not wait an promise. This bug was caused by
request.ts when I override the internal variable of stream _readableState, with this, the NestJS
could not process the request and the process exits after some seconds without exit code.
Refs:
Description of change
I just remove the overrides in internal state of the stream.
Pull-Request Checklist
mainbranchnpm run lintpasses with this changenpm run testpasses with this change