Skip to content

Conversation

@mattjala
Copy link
Contributor

@mattjala mattjala commented Sep 16, 2025

Depends on #5800


Important

Optimize VDS operations using R-tree spatial index, adding new API functions and tests for improved performance.

  • Behavior:
    • Introduces R-tree spatial index for optimizing VDS operations in H5Dvirtual.c.
    • Adds H5Pset_dset_use_spatial_tree() and H5Pget_dset_use_spatial_tree() to control R-tree usage.
    • Default behavior uses R-tree for VDS with more than 1000 mappings.
  • Implementation:
    • Adds H5RT.c, H5RTprivate.h, and H5RTpkg.h for R-tree implementation.
    • Updates H5Pdapl.c and H5Pdcpl.c to include R-tree properties.
    • Modifies H5Dvirtual.c to integrate R-tree in VDS I/O operations.
  • Testing:
    • Adds rtree.c for testing R-tree creation, search, and copy operations.
    • Tests R-tree integration with VDS in test/dsets.c.
    • Verifies R-tree behavior with different dataset access property list settings.

This description was created by Ellipsis for afc2e51. You can customize this summary. It will automatically update as commits are pushed.

@mattjala mattjala added this to the Release 2.0.0 milestone Sep 16, 2025
@mattjala mattjala added the Component - C Library Core C library issues (usually in the src directory) label Sep 16, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in HDF5 - TRIAGE & TRACK Sep 16, 2025
@mattjala mattjala force-pushed the vds_tree_rtree branch 2 times, most recently from 62165aa to ca2742b Compare September 18, 2025 19:46
@mattjala mattjala marked this pull request as ready for review September 19, 2025 13:51
@brtnfld

This comment was marked as outdated.

@mattjala

This comment was marked as outdated.

@nbagha1 nbagha1 moved this from To be triaged to Scheduled/On-Deck in HDF5 - TRIAGE & TRACK Sep 22, 2025
brtnfld

This comment was marked as resolved.

@github-project-automation github-project-automation bot moved this from Scheduled/On-Deck to In progress in HDF5 - TRIAGE & TRACK Sep 22, 2025
jhendersonHDF
jhendersonHDF previously approved these changes Oct 3, 2025
Copy link
Collaborator

@jhendersonHDF jhendersonHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good; see remaining comment though

@lrknox lrknox merged commit ac169ed into HDFGroup:develop Oct 7, 2025
174 of 175 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in HDF5 - TRIAGE & TRACK Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component - C Library Core C library issues (usually in the src directory)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants