Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows CI and build script #127

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add Windows CI and build script #127

wants to merge 16 commits into from

Conversation

mattjala
Copy link
Collaborator

@mattjala mattjala commented Apr 15, 2024 •
edited
Loading

  • Added workflow to build and test on Windows with CMake
  • Populated build_vol_cmake.bat to replicate build_vol_cmake.sh
  • Various CMake changes so that YAJL and cURL can be discovered on Windows. The github runners don't seem to have a FindCURL module, so the CMake now defines CURL_LIBRARIES and CURL_INCLUDE_DIRS relative to the provided CURL_ROOT.

Changes to the VOL for Windows compatibility:

  • Replaced clock_gettime with RV_now_usec, which uses one of clock_gettime, gettimeofday, or time.
  • Replaced strtok_r with cross-platform strtok

Resolves #116

@mattjala mattjala added enhancement New feature or request testing Related to testing process labels Apr 15, 2024
@mattjala mattjala self-assigned this Apr 15, 2024
@mattjala mattjala force-pushed the windows_compatibility branch 3 times, most recently from fc8789f to 2b1fc5a Compare April 15, 2024 19:54
@mattjala mattjala marked this pull request as ready for review April 19, 2024 22:06
jhendersonHDF
jhendersonHDF reviewed Apr 29, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 29, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 29, 2024
View reviewed changes
src/rest_vol.c Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 29, 2024
View reviewed changes
CMake/FindYAJL.cmake Outdated Show resolved Hide resolved
jhendersonHDF
jhendersonHDF reviewed Apr 29, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mattjala mattjala

Labels
enhancement New feature or request testing Related to testing process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test support for Windows in CI
2 participants
@mattjala @jhendersonHDF