Enable noise for ALLEGRO ECAL barrel cells #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,9 +55,9 @@ | |||
| # | |||
| inputfile = "ALLEGRO_sim.root" # input file produced with ddsim | |||
| Nevts = -1 # -1 means all events | |||
| addNoise = False # add noise or not to the cell energy | |||
| addNoise = True # add noise or not to the cell energy | |||
There was a problem hiding this comment.
Till filtering works, I would set addNoise to False by default - to avoid producing huge output files
There was a problem hiding this comment.
Till filtering works, I would set addNoise to False by default - to avoid producing huge output files
-
I would set addNoise to False by default
Agree. -
Till filtering works
As discussed previously in the email thread, the noise filter does not work in an intended way. Brieuc has come up with a solution. But I haven't implemented it
There was a problem hiding this comment.
addNoise is switched off by default.
| readoutName=ecalBarrelReadoutName, | ||
| activeVolumeName="LAr_sensitive", | ||
| activeFieldName="layer", | ||
| activeVolumesNumber=11, |
There was a problem hiding this comment.
We commented in HEP-FCC/k4RecCalorimeter#107 that the activeVolumesNumber property should be dropped
Co-authored-by: Giovanni Marchiori <39376142+giovannimarchiori@users.noreply.github.com>
|
Superseded by #204 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full simulation of ALLEGRO can be performed with noise on ECAL barrel cells.