move main ALLEGRO tests to ddsim+k4run

[giovannimarchiori]

Move ALLEGRO tests to ddsim + k4run, and reduce number of tests

WIP: need to include in main test clustering with x-talk (and remove the last test FCCeeLar_runxtalk)

There are two tests (FCCeeLar_benchmarkCalibration and FCCeeLAr_benchmarkCorrection) for which I think that:

• the former (FCCeeLar_benchmarkCalibration) is obsolete and could probably be dropped, and is basically superseded by the latter
• the latter (FCCeeLAr_benchmarkCorrection) only works for ECAL barrel + HCAL barrel clusters, but the new ALLEGRO_o1_v03_digi_reco.py test script has CaloClusters assembled from all calorimeter systems, so we should decide whether the benchmark correction tool should be migrated to those clusters or whether for testing purposes only we create a collection with only barrel ECAL+HCAL cells included.

[giovannimarchiori]

Hi @BrieucF I think this PR is now ready for review, the new test supersedes a few tests and can then serve also as a template for run_digi_reco in FCC-config. When new tools are added (new cell digitisation + positioning tool, noise..) we can then create further PRs to update the test - or modify the test directly in the PRs implementing the new algorithms.

[BrieucF]

Hi Giovanni, it looks good! Thanks! The test should be modified whithin the PR adding a new functionality in k4RecCalorimeter ;-)

[BrieucF]

@kjvbrt is this ok for you?

[giovannimarchiori]

Hi @kjvbrt, @BrieucF,
I pushed some small updates accounting for the comments of @kjvbrt. Once the tests are successful can we approve and merge?

[kjvbrt]

It is easier to check for the non-zero return value with:

ddsim .... || exit 1

This will exit the script with 1 if ddsim returnns non zero value (the commands for or are evaluated from left to right and if the result of the first command is already true the second command is skipped).

[giovannimarchiori]

ok will fix in next PR