Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup to PR #107 (noise handling) #114

Merged

Conversation

giovannimarchiori
Copy link
Contributor

Fixes a few things of #107

  • avoid hardcoded systemID value, retrieve it from configurables
  • nonworking code removed
  • move the TubeLayer tool to RecFCCeeCalorimeter where other "vsTheta" tools live
  • remove the test script based on legacy configs and implement noise+filtering in test based on ddsim+k4run

@giovannimarchiori giovannimarchiori changed the title Folloup to PR #107 (noise handling) Followup to PR #107 (noise handling) Sep 13, 2024
@kjvbrt
Copy link
Contributor

kjvbrt commented Sep 17, 2024

Thanks @giovannimarchiori, this is the last PR before I make a release.

@kjvbrt kjvbrt merged commit 5e8879e into HEP-FCC:main Sep 17, 2024
2 of 5 checks passed
@giovannimarchiori giovannimarchiori deleted the gmarchio-main-20240913-fixnoisePR107 branch October 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants