Skip to content

Les houches example#314

Merged
vschutze-alt merged 52 commits intomainfrom
les_houches_example
May 29, 2025
Merged

Les houches example#314
vschutze-alt merged 52 commits intomainfrom
les_houches_example

Conversation

@vschutze-alt
Copy link
Collaborator

Added an example showing how to use colibri to perform a fit for the Les Houches parametrisation.

@codecov
Copy link

codecov bot commented Mar 31, 2025

The author of this PR, vschutze-alt, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

Copy link
Member

@comane comane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder structure should be something like

les_houches_example/les_houches

where in the les_houches_example folder there is a pyproject.toml file that allows one to install a les_houches exec and in the les_houches folder there is the model definition.

Moreover, I would suggest that we try run a model-specific closure test, rather than generating the Level0 data from an NNPDF pdf

@comane
Copy link
Member

comane commented Apr 6, 2025

Hi @vschutze-alt in order to do model specific closure tests you need to add to the runcard something like:

closure_test_pdf: colibri_model
closure_test_model_settings:
  model: les_houches_example

and then specify the input values for the parameters.

Here is the PR in which model specific closure tests were introduced: #280

@comane
Copy link
Member

comane commented Apr 6, 2025

Also, please change all the names from example to les houches in a consistent way.
It will be much easier doing it now rather than in a month.

@vschutze-alt vschutze-alt force-pushed the les_houches_example branch from 299054f to bca4501 Compare April 9, 2025 13:44
@comane comane linked an issue Apr 27, 2025 that may be closed by this pull request
@ElieHammou ElieHammou mentioned this pull request Apr 28, 2025
@comane comane requested a review from LucaMantani May 26, 2025 14:17
Copy link
Member

@LucaMantani LucaMantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, in particular the fitted_flavours variable was still around but never used, I suggested to remove it everywhere.

Copy link
Member

@LucaMantani LucaMantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@comane
Copy link
Member

comane commented May 27, 2025

Before merging, can we have a list of sanity checks that the model is actually physical?

I would like to see sum rules conservation especially to hold

@comane
Copy link
Member

comane commented May 28, 2025

Something else that would be great to have, I'll add it to the list of 1.0, is a model-specific .github workflow using the les houches model, instead on relying on any external models, to test that the model-scpecific closure tests are working fine and are not broken by some changes.

vschutze-alt and others added 25 commits May 28, 2025 11:31
Co-authored-by: Mark Nestor Costantini <85164495+comane@users.noreply.github.com>
…g.py

Co-authored-by: Mark Nestor Costantini <85164495+comane@users.noreply.github.com>
…g.py

Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
…est.yaml

Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
@LucaMantani LucaMantani force-pushed the les_houches_example branch from e2f9483 to 3cf2a5c Compare May 28, 2025 13:57
@vschutze-alt vschutze-alt merged commit 7fa77db into main May 29, 2025
4 checks passed
@comane comane deleted the les_houches_example branch May 29, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a fixed form parameterisation

3 participants