Conversation
|
The author of this PR, vschutze-alt, is not an activated member of this organization on Codecov. |
comane
left a comment
There was a problem hiding this comment.
the folder structure should be something like
les_houches_example/les_houches
where in the les_houches_example folder there is a pyproject.toml file that allows one to install a les_houches exec and in the les_houches folder there is the model definition.
Moreover, I would suggest that we try run a model-specific closure test, rather than generating the Level0 data from an NNPDF pdf
|
Hi @vschutze-alt in order to do model specific closure tests you need to add to the runcard something like: and then specify the input values for the parameters. Here is the PR in which model specific closure tests were introduced: #280 |
colibri/examples/les_houches_example/runcards/les_houches_runcard.yaml
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/les_houches_example/model.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/les_houches_example/config.py
Outdated
Show resolved
Hide resolved
|
Also, please change all the names from example to les houches in a consistent way. |
colibri/examples/les_houches_example/les_houches_example/config.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/les_houches_example/config.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/runcard/les_houches_runcard.yaml
Outdated
Show resolved
Hide resolved
299054f to
bca4501
Compare
colibri/examples/les_houches_example/les_houches_example/config.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/les_houches_example/app.py
Outdated
Show resolved
Hide resolved
LucaMantani
left a comment
There was a problem hiding this comment.
I left a few comments, in particular the fitted_flavours variable was still around but never used, I suggested to remove it everywhere.
colibri/examples/les_houches_example/les_houches_example/config.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/les_houches_example/model.py
Outdated
Show resolved
Hide resolved
colibri/examples/les_houches_example/runcards/lh_fit_closure_test.yaml
Outdated
Show resolved
Hide resolved
|
Before merging, can we have a list of sanity checks that the model is actually physical? I would like to see sum rules conservation especially to hold |
|
Something else that would be great to have, I'll add it to the list of 1.0, is a model-specific .github workflow using the les houches model, instead on relying on any external models, to test that the model-scpecific closure tests are working fine and are not broken by some changes. |
… and enabled the executable run_colibri
…sis elements, with an updated theory
Co-authored-by: Mark Nestor Costantini <85164495+comane@users.noreply.github.com>
…g.py Co-authored-by: Mark Nestor Costantini <85164495+comane@users.noreply.github.com>
…g.py Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
…est.yaml Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
Co-authored-by: Luca Mantani <luca.mantani@gmail.com>
e2f9483 to
3cf2a5c
Compare
Added an example showing how to use colibri to perform a fit for the Les Houches parametrisation.