Refactor covariance matrix production rule and rename explicit node#432
Refactor covariance matrix production rule and rename explicit node#432
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 94.96% 95.00% +0.03%
==========================================
Files 31 31
Lines 1649 1642 -7
==========================================
- Hits 1566 1560 -6
+ Misses 83 82 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Analytical L1 fit fails because the runcard does not have the |
|
Why did you decide to remove it? What was the reason for us to have the different covmats before? |
The reason was having the possibility of generating pseudodata (in the MC replica method) with the experimental covariance matrix rather than the t0-modified covariance matrix that we use in the fit. However, the NNPDF standard now is to use also t0-covmat in the pseudodata generation. |
… (explicit node) and renamed the covariance matrix explicit node to general_covariance_matrix
…aced it directly with central_covmat_index
12f7013 to
21cb95f
Compare
This removes the need for the
use_gen_t0key in the runcard.