Skip to content

Refactor covariance matrix production rule and rename explicit node#432

Open
comane wants to merge 7 commits intomainfrom
remove_data_generation_covariance_matrix
Open

Refactor covariance matrix production rule and rename explicit node#432
comane wants to merge 7 commits intomainfrom
remove_data_generation_covariance_matrix

Conversation

@comane
Copy link
Member

@comane comane commented Mar 19, 2026

This removes the need for the use_gen_t0 key in the runcard.

@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (cf4d16e) to head (21cb95f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   94.96%   95.00%   +0.03%     
==========================================
  Files          31       31              
  Lines        1649     1642       -7     
==========================================
- Hits         1566     1560       -6     
+ Misses         83       82       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comane
Copy link
Member Author

comane commented Mar 20, 2026

Analytical L1 fit fails because the runcard does not have the use_gen_t0 set to True.

@LucaMantani
Copy link
Member

Why did you decide to remove it? What was the reason for us to have the different covmats before?

@comane
Copy link
Member Author

comane commented Mar 20, 2026

Why did you decide to remove it? What was the reason for us to have the different covmats before?

The reason was having the possibility of generating pseudodata (in the MC replica method) with the experimental covariance matrix rather than the t0-modified covariance matrix that we use in the fit.

However, the NNPDF standard now is to use also t0-covmat in the pseudodata generation.

@comane comane force-pushed the remove_data_generation_covariance_matrix branch from 12f7013 to 21cb95f Compare March 20, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants