Skip to content

Refactor analytical fit to use QR decomposition and remove central covariance#433

Merged
comane merged 10 commits intomainfrom
remove_central_inv_covmat
Mar 20, 2026
Merged

Refactor analytical fit to use QR decomposition and remove central covariance#433
comane merged 10 commits intomainfrom
remove_central_inv_covmat

Conversation

@comane
Copy link
Member

@comane comane commented Mar 20, 2026

What this PR does:

  • removes the central_inv_covmat_index object. The object was not really necessary and only used within the analytical fit
  • Refactors the analytical fit so as to efficiently make use of QR decomposition in solving the GLS.

@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.96%. Comparing base (74b9b9f) to head (2b2efe2).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   94.98%   94.96%   -0.02%     
==========================================
  Files          31       31              
  Lines        1654     1649       -5     
==========================================
- Hits         1571     1566       -5     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@LucaMantani LucaMantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@comane comane merged commit cf4d16e into main Mar 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants