Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use numpy=2 and pyuvdata=3 #319

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Update to use numpy=2 and pyuvdata=3 #319

merged 10 commits into from
Aug 5, 2024

Conversation

steven-murray
Copy link
Contributor

This will probably not run OK until HERA-Team/hera_cal#959 is merged.

This adds support for numpy2 and pyuvdata 3.0.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.28%. Comparing base (abe6743) to head (2be06c3).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
hera_sim/simulate.py 66.66% 0 Missing and 1 partial ⚠️
hera_sim/vis.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   93.40%   93.28%   -0.12%     
==========================================
  Files          25       25              
  Lines        3396     3396              
  Branches      732      731       -1     
==========================================
- Hits         3172     3168       -4     
- Misses        120      122       +2     
- Partials      104      106       +2     
Flag Coverage Δ
unittests 93.25% <93.75%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! This all looks good, except for one issue that needs to be fixed (I left a comment explaining the issue and how to fix it). I figure we ought to add a test that will break in case this mistake is made again in the future, but I'll need some time to think about how to execute that test.

hera_sim/adjustment.py Outdated Show resolved Hide resolved
hera_sim/adjustment.py Outdated Show resolved Hide resolved
hera_sim/adjustment.py Outdated Show resolved Hide resolved
hera_sim/defaults.py Outdated Show resolved Hide resolved
@steven-murray
Copy link
Contributor Author

Thanks @r-pascua for the good review. I've addressed your points now!

Copy link
Contributor

@r-pascua r-pascua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @steven-murray!

hera_sim/adjustment.py Outdated Show resolved Hide resolved
@steven-murray steven-murray merged commit 4e0f1e7 into main Aug 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants