-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use numpy=2 and pyuvdata=3 #319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 93.40% 93.28% -0.12%
==========================================
Files 25 25
Lines 3396 3396
Branches 732 731 -1
==========================================
- Hits 3172 3168 -4
- Misses 120 122 +2
- Partials 104 106 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! This all looks good, except for one issue that needs to be fixed (I left a comment explaining the issue and how to fix it). I figure we ought to add a test that will break in case this mistake is made again in the future, but I'll need some time to think about how to execute that test.
Thanks @r-pascua for the good review. I've addressed your points now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @steven-murray!
This will probably not run OK until HERA-Team/hera_cal#959 is merged.
This adds support for numpy2 and pyuvdata 3.0.