Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3540] AWS Pinpoint Mock setup #3652

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Conversation

chouinar
Copy link
Collaborator

Summary

Fixes #3540

Time to review: 5 mins

Changes proposed

Adds basic setup to call AWS Pinpoint

Handles mocking queries for local development / unit tests

Context for reviewers

AWS Pinpoint is an AWS service we'll be using for sending email notifications to users. We don't yet have any of the infra setup for it, but the Nava infra template does have it setup, and I used it to test the behavior.

There will be more configuration needed in the future for things like the app ID, but I wasn't sure exactly how we'll manage that (one app per notification type, or just per env? Will leave to design to sort out).

We also won't send raw HTML emails and will instead setup email templates most likely which will require adjusting some of the parameters we pass in.

Additional information

With a quick local script, I was able to pass in a few parameters and send myself some emails:

Screenshot 2025-01-27 at 3 39 36 PM

I used this to verify the format of the response could be parsed / was setup correctly.

@chouinar chouinar merged commit e93658b into main Jan 30, 2025
2 checks passed
@chouinar chouinar deleted the chouinar/3540-aws-pinpoint-mock branch January 30, 2025 20:30
DavidDudas-Intuitial pushed a commit that referenced this pull request Feb 7, 2025
## Summary
Fixes #3540 

### Time to review: __5 mins__

## Changes proposed
Adds basic setup to call AWS Pinpoint

Handles mocking queries for local development / unit tests

## Context for reviewers
AWS Pinpoint is an AWS service we'll be using for sending email
notifications to users. We don't yet have any of the infra setup for it,
but the Nava infra template does have it setup, and I used it to test
the behavior.

There will be more configuration needed in the future for things like
the app ID, but I wasn't sure exactly how we'll manage that (one app per
notification type, or just per env? Will leave to design to sort out).

We also won't send raw HTML emails and will instead setup email
templates most likely which will require adjusting some of the
parameters we pass in.

## Additional information
With a quick local script, I was able to pass in a few parameters and
send myself some emails:

![Screenshot 2025-01-27 at 3 39
36 PM](https://github.com/user-attachments/assets/750e9492-7560-4551-9d65-e7d37bba1b83)

I used this to verify the format of the response could be parsed / was
setup correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add mocking support for AWS Pinpoint
2 participants