[Issue #3685] Save search get opportunity id #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
reviewed
Jan 31, 2025
|
@babebe - could you make sure your PR title follows our usual format? Should be: |
babebe
changed the title
babebe
changed the title
… 3685/save-search-get-opp-id
… 3685/save-search-get-opp-id
babebe
changed the title
chouinar
previously approved these changes
Feb 3, 2025
… 3685/save-search-get-opp-id
chouinar
approved these changes
Feb 4, 2025
DavidDudas-Intuitial
pushed a commit
that referenced
this pull request
Feb 7, 2025
## Summary
Fixes [#{3685}](#3685)
### Time to review: __10 mins__
## Changes proposed
Query the search index limiting the results to only opportunity ID
Store the list of opportunity IDs returned to the DB as a list/array
(does not need to point to opportunity table as foreign keys)
Modify the users query to replace with static pagination
## Additional information
Updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #{3685}
Time to review: 10 mins
Changes proposed
Query the search index limiting the results to only opportunity ID
Store the list of opportunity IDs returned to the DB as a list/array (does not need to point to opportunity table as foreign keys)
Modify the users query to replace with static pagination
Additional information
Updated tests