[Issue #1485] return last page of search if requested page is out of bounds #3796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
changed the title
doug-s-nava
commented
Feb 7, 2025
| useEffect(() => { | ||
| console.error(error); | ||
| }, [error]); | ||
|
|
There was a problem hiding this comment.
not sure how this came back, and the above change I think I also handled in a previous PR 🤷
doug-s-nava
force-pushed
the
dschrashun/1485-max-page-redirect
branch
from
67a3a0a to
7b7957a
Compare
doug-s-nava
requested review from
acouch,
andycochran and
btabaska
as code owners
doug-s-nava
commented
Feb 7, 2025
| const t = await getTranslations("Search"); | ||
|
|
||
| if ( |
There was a problem hiding this comment.
where this is being done is more or less arbitrary since the same promise is being awaited in multiple components. That seems weird, which is one of the reasons I did the refactor in #3796
doug-s-nava
force-pushed
the
dschrashun/1485-max-page-redirect
branch
from
7b7957a to
f520216
Compare
doug-s-nava
commented
Feb 7, 2025
| body: "<li>Check any terms you've entered for typos</li><li>Try different keywords</li><li>Make sure you've selected the right statuses</li><li>Try resetting filters or selecting fewer options</li>", | ||
| paginationError: | ||
| "You're trying to access opportunity results that are beyond the last page of data.", | ||
| noResultsTitle: "Your search did not return any results.", |
There was a problem hiding this comment.
just updating the names here as they were confusing me when working with this component
doug-s-nava
force-pushed
the
dschrashun/1485-max-page-redirect
branch
from
fcf6dfe to
7d7d728
Compare
…bounds * updates page query param in url if requested page exceeds total number of pages * removes remnants of previous "maxPageError"
doug-s-nava
force-pushed
the
dschrashun/1485-max-page-redirect
branch
from
79c4554 to
d2519bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1485
Time to review: 15 mins
Changes proposed
If the page of search results requested exceeds the total number of pages returned by the API, this updates the page query param to the last page of results, triggering a new search request.
Includes removal of some leftovers from the previous "maxPageError" implementation, and cleans up a couple other things too.
Worth noting that I tried solving this on the API side first, which you can see in 423d730. The issue with that is that there was no easy way to update the url to reflect the change, which seemed bad.
Context for reviewers
Test steps
npm run devon this branchAdditional information