[Issue 943] Cleanup various API components, improve test coverage #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
reviewed
Dec 29, 2023
| @@ -231,9 +233,6 @@ lint-security: # https://bandit.readthedocs.io/en/latest/index.html | |||
| cmd: ## Run Flask app CLI command (Run `make cli args="--help"` to see list of CLI commands) | |||
| $(FLASK_CMD) $(args) | |||
|
|
|||
| cmd-user-create-csv: ## Create a CSV of the useres in the database (Run `make cli-user-create-csv args="--help"` to see the command's options) | |||
There was a problem hiding this comment.
Thanks for removing this and the sleep target!
acouch
approved these changes
Dec 29, 2023
There was a problem hiding this comment.
(praise) nice!
looks like some of this could be committed upstream. We could make an issue if you feel so inspired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #943
Time to review: 10 mins
Changes proposed
Improved test coverage from 84% to 92%
Add audit log tests to test coverage
Fix audit log tests to not try to commit code
Remove miscellaneous unused components in the Makefile
Adjust the location of several tests which were nested in a different directory than the rest of the tests.
Add various utility tests
Context for reviewers
This is a random assortment of little things. I started by fixing up some of the paths, and then noticed our test coverage was lower than I expected, so fixed the configurations / tests.
Most of these tests I didn't write here, and puled from other projects based on the template repo - need to backport those tests into the template as they shouldn't be missing there.
Additional information
make test-coveragewill run the tests with branch coverage, then runningmake test-coverage-reportwill pull up an HTML page with the actual coverage metrics line-by-line which I used to figure out what wasn't being tested.