[Issue #446] Fixes script to generate release notes#448
Merged
Conversation
The script failed if it received `--previous-tag ""` as an option because the script only ignored the previous tag if it was omitted or received no argument. This updates the option parsing to also skip the previous tag if it receives an empty string `""`
jcrichlake
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes how the
validate-and-generate-release-notes.shhandles the option--previous-tag ""which was breaking the CD workflows that were triggered without providing a previous tag.Changes proposed
validate-and-generate-release-notes.shto skip over the--previous-tagoption when passed an empty string""Context for reviewers
The script failed if it received
--previous-tag ""as an option because the script only ignored the previous tag if it was omitted or received no argument. This updates the option parsing to also skip parsing the previous tag option when set to an empty string""Additional information
Testing locally
mainby running this from the root of the repo. It should fail withUnknown option:Testing with GitHub action
Here's a dry run with the CLI workflow.
And here's another test with the Py SDK workflow: