Skip to content

Comments

[Issue #490] Small dependency bump#498

Merged
jcrichlake merged 6 commits intomainfrom
490-core-cli-dependencies
Feb 11, 2026
Merged

[Issue #490] Small dependency bump#498
jcrichlake merged 6 commits intomainfrom
490-core-cli-dependencies

Conversation

@jcrichlake
Copy link
Collaborator

@jcrichlake jcrichlake commented Feb 10, 2026 •
edited
Loading

Summary

Changes proposed

What was added, updated, or removed in this PR.

Updated TypeSpec peer dependencies in the pnpm-workspace file which then trickled the updates down to the cli and core module of the repository. There is also an update for the axios library which was flagged for being vulnerable to DDoS attacks as part of the CI checks.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

  • Checkout branch
  • Run pnpm pack in the CLI module
  • Install the generated tarball globally
  • Created new empty directory
  • Ran cg init
  • ran npm install --legacy-peer-deps
  • Validated that all 4 commands worked in the directory.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@github-actions github-actions bot added cli Issue or PR related to the @common-grants/cli library core Issues related to @common-grants/core library typescript Issue or PR related to TypeScript tooling labels Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026 •
edited
Loading

🚀 Website Preview Deployed!

Preview your changes at: https://cg-pr-498.billy-daly.workers.dev

This preview will be automatically deleted when the PR is closed.

@jcrichlake jcrichlake requested a review from widal001 February 10, 2026 20:24
@jcrichlake jcrichlake marked this pull request as ready for review February 10, 2026 21:45
@widal001 widal001 changed the title Small dependency bump [Issue #490] Small dependency bump Feb 11, 2026
@widal001
build: Adopts pnpm catalog
7d7c80c 
This allows us to define default dep versions once and re-use them
across the workspace
@widal001
build: Update deps
aaba98a 
Updates lib/core and lib/cli to use catalog
Switches @common-grants/core
from direct to dev dependency in CLI
@widal001
refactor(cli): Saves changes to generated OpenAPI docs
1c566ae 
The switch to the latest compiler fixes a bug in how the OpenAPI docs
are generated which caused some examples to get dropped
@widal001
build: Adds changeset for patch release
34140cb
widal001
widal001 reviewed Feb 11, 2026
View reviewed changes
lib/cli/lib/openapi/openapi.0.1.0.yaml
Comment on lines +821 to +825
postDate:
name: Application posted date
eventType: singleDate
date: '2024-01-15'
description: Opportunity is posted publicly
Copy link
Collaborator

@widal001 widal001 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These examples are preserved due to the switch to the latest @typespec/compiler and @typespec/openapi3

widal001
widal001 reviewed Feb 11, 2026
View reviewed changes
lib/core/package.json
Comment on lines +54 to +55
"@typespec/compiler": "catalog:",
"@typespec/http": "catalog:",
Copy link
Collaborator

@widal001 widal001 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New syntax for using pnpm catalog

widal001
widal001 reviewed Feb 11, 2026
View reviewed changes
.changeset/sharp-seas-fold.md
Copy link
Collaborator

@widal001 widal001 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This enables us to to a patch release of both @common-grants/core and @common-grants/cli

widal001
widal001 approved these changes Feb 11, 2026
View reviewed changes
Copy link
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcrichlake Looks like v1.9.0 was just released for TypeSpec libraries. So I used this as an opportunity to switch to the pnpm catalog feature you flagged.

I also used this as an opportunity to switch @common-grants/core from a direct dependency to a dev dependency in the CLI, which helped resolve some lingering peer dependency warnings I was getting when I ran pnpm pack and npm install <path-to-tarball> -g. See screenshots below:

Testing local install

Image

cg init

Image

cg check spec

Spec passes when auto-generated from FastAPI template
Image

Spec fails as expected when I change the auto-generated FastAPI docs
Image

cg preview

Image

Testing pnpm changeset version

I also checked to make sure the versions were getting bumped properly using the changeset I added:

Image

@jcrichlake
Copy link
Collaborator Author

jcrichlake commented Feb 11, 2026

I also validated the changes after Billy's updates. Proceeding with the merge

@jcrichlake jcrichlake merged commit 4ad6c73 into main Feb 11, 2026
11 checks passed
@jcrichlake jcrichlake deleted the 490-core-cli-dependencies branch February 11, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@widal001 widal001 widal001 approved these changes

Assignees

No one assigned

Labels

cli Issue or PR related to the @common-grants/cli library core Issues related to @common-grants/core library typescript Issue or PR related to TypeScript tooling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Core/CLI] Update core and CLI library dependencies

2 participants

@jcrichlake @widal001