[Issue #319] Prepare @common-grants/core minor release#505
Merged
Conversation
* feat(core): Adds 0.3.0 to the Versions enum * refactor(core): Renamed Form --> FormBase * feat(core): Adds missing fields to Form model * feat(core): Adds new fields and models for application * feat(core): Adds examples to application filters * feat(core): Adds app search endpoint and review tag * docs(core): Improve examples for application
Previously we omitted @Versioning.added() decorator for schemas added in v0.1.0 but that caused some v0.2.0 models to get inferred as v0.1.0. This makes all versioning explicit.
- Update all `@types/node` deps to use `"catalog:"` - Updates website to use "workspace:*" for `@common-grants/core` - Updates website to set all `@typespec/` deps to use `"catalog:"`
The switch to the latest @typespec/compiler version improved how the example values were generated
github-actions
bot
added
cli
Contributor
|
🚀 Website Preview Deployed! Preview your changes at: https://cg-pr-505.billy-daly.workers.dev This preview will be automatically deleted when the PR is closed. |
Allows both EquivalenceOperator and ComparisonOperator
Auto-updates the OpenAPI specs generated from `@common-grants/core` These OpenAPI specs are used by `check spec`
We updated the core library to accept Equivalence operators so we need the schemas to accept them as well
widal001
commented
Feb 12, 2026
Collaborator
Author
There was a problem hiding this comment.
The changes to the previous OpenAPI versions are mainly to the examples and descriptions, which we can't version like we can the fields and schemas themselves.
widal001
commented
Feb 12, 2026
|
|
||
| export const NumberComparisonFilterSchema = z.object({ | ||
| operator: ComparisonOperatorsEnum, | ||
| operator: z.union([ComparisonOperatorsEnum, EquivalenceOperatorsEnum]), |
Collaborator
Author
There was a problem hiding this comment.
Updating this to match the change in @common-grants/core Luckily it was caught by the property based testing we have set up in the TypeScript SDK 🎉
jcrichlake
reviewed
Feb 13, 2026
jcrichlake
reviewed
Feb 13, 2026
jcrichlake
approved these changes
Feb 14, 2026
Contributor
|
🗑️ Preview Cleaned Up The preview for this PR has been automatically deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes proposed
lib/corefor v0.3.0 release@Versioning.added()decorator to all schemasPOST /common-grants/applications/search/and a set of supporting modelsNumberComparisonFilter.operatortype toComparisonOperators | EquivalenceOperatorsso that we can filter usingeqandneqin addition toge,gte, etc.lib/clifor v0.3.0 releasecg check speccatalog:for@types/nodelib/ts-sdk/(pausing on v0.5.0 release for custom field support)NumberComparisonFilterSchemato supportEquivalenceOperatorsas wellcatalog:for@types/node@common-grants/coretoworkspace:*dependency (instead of external library)catalog:for all@typespec/dependenciesSchemaFormatTabscomponentContext for reviewers
Testing website
Testing CLI changes
pnpm packandnpm install -g <path-to-tarball>/templates/fast-api/and runmake check-specAdditional information
Updated docs with v0.3.0
Checking that FastAPI template still passes
cg check specConfirming that the shift to v0.3.0 doesn't break existing implementations
The result of running
pnpm changeset version