[Issue #493] Standardize Checks and CI Across the Project

.github/workflows/ci-lib-changelog-emitter.yml

@@ -34,11 +34,11 @@ jobs:
       - name: Build library
         run: pnpm --filter typespec-versioning-changelog run build
 
-      - name: Lint and format
+      - name: Run checks
         run: pnpm --filter typespec-versioning-changelog run checks
 
       - name: Run tests
-        run: pnpm --filter typespec-versioning-changelog test
+        run: pnpm --filter typespec-versioning-changelog run test:coverage
 
       - name: Audit dependencies
-        run: pnpm audit
+        run: pnpm --filter typespec-versioning-changelog run audit

.github/workflows/ci-lib-cli.yml

@@ -36,14 +36,14 @@ jobs:
       - name: Build core library
         run: pnpm --filter @common-grants/core run build
 
-      - name: Lint and format
+      - name: Run checks
         run: pnpm --filter @common-grants/cli run checks
 
       - name: Run tests
-        run: pnpm --filter @common-grants/cli test
+        run: pnpm --filter @common-grants/cli run test:coverage
 
       - name: Build library
         run: pnpm --filter @common-grants/cli run build
 
       - name: Audit dependencies
-        run: pnpm audit
+        run: pnpm --filter @common-grants/cli run audit

.github/workflows/ci-lib-core.yml

@@ -33,7 +33,7 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
-      - name: Lint and format
+      - name: Run checks
         run: pnpm --filter @common-grants/core run checks
 
       - name: Build library
@@ -43,4 +43,4 @@ jobs:
         run: pnpm --filter @common-grants/core run typespec
 
       - name: Audit dependencies
-        run: pnpm audit
+        run: pnpm --filter @common-grants/core run audit

.github/workflows/ci-lib-pysdk.yml

@@ -29,22 +29,13 @@ jobs:
         run: poetry self add poetry-audit-plugin
 
       - name: Install dependencies
-        run: poetry install
+        run: make install
 
-      - name: Audit dependencies for vulnerabilities
-        run: poetry audit
-
-      - name: Run linting
-        run: poetry run ruff check .
-
-      - name: Run formatting
-        run: poetry run black . --check
-
-      - name: Run type checking
-        run: poetry run mypy .
+      - name: Run linting, formatting, and type checking
+        run: make checks
 
       - name: Run tests
-        run: poetry run pytest
+        run: make test
 
       - name: Build package
-        run: poetry build
+        run: make build

.github/workflows/ci-lib-ts-sdk.yml

@@ -33,14 +33,14 @@ jobs:
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
-      - name: Build SDK library
+      - name: Build library
         run: pnpm --filter @common-grants/sdk run build
 
-      - name: Lint and format
+      - name: Run checks
         run: pnpm --filter @common-grants/sdk run checks
 
       - name: Run tests
-        run: pnpm --filter @common-grants/sdk test:coverage
+        run: pnpm --filter @common-grants/sdk run test:coverage
 
       - name: Audit dependencies
-        run: pnpm audit
+        run: pnpm --filter @common-grants/sdk run audit

lib/changelog-emitter/package.json

@@ -18,14 +18,15 @@
     "@typespec/versioning": "catalog:"
   },
   "devDependencies": {
+    "@eslint/js": "^9.15.0",
     "@types/node": "catalog:",
     "@typespec/prettier-plugin-typespec": "^1.5.0",
     "eslint": "^9.15.0",
-    "@eslint/js": "^9.15.0",
     "prettier": "^3.3.3",
     "typescript": "^5.3.3",
     "typescript-eslint": "^8.15.0",
-    "vitest": "^3.2.4"
+    "vitest": "^3.2.4",
+    "@vitest/coverage-v8": "^3.2.4"
   },
   "scripts": {
     "build": "tsc",
@@ -37,7 +38,9 @@
     "format": "prettier .  --write",
     "check:format": "prettier --check .",
     "check:lint": "eslint . --report-unused-disable-directives --max-warnings=0",
-    "checks": "pnpm run check:lint && pnpm run check:format"
-  },
-  "packageManager": "npm@11.6.2+sha512.ee22b335fcbc95662cdf3ab8a053daf045d9cf9c6df6040d28965abb707512b2c16fa6c5eec049d34c74f78f390cebd14f697919eadb97756564d4f9eccc4954"
+    "check:types": "tsc --noEmit",
+    "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",
+    "test:coverage": "vitest run --coverage --coverage.reporter=text",
+    "audit": "pnpm audit"
+  }
 }

lib/cli/package.json

@@ -35,10 +35,10 @@
     "opportunities"
   ],
   "scripts": {
-    "build": "npm run typespec && tsc",
+    "build": "pnpm run typespec && tsc",
     "typespec:clean": "rm -rf dist tsp-output && rm -rf lib/openapi/*",
     "typespec:openapi": "tsp compile lib/main.tsp --emit @typespec/openapi3 && cp tsp-output/@typespec/openapi3/** lib/openapi",
-    "typespec": "npm run typespec:clean && npm run typespec:openapi",
+    "typespec": "pnpm run typespec:clean && pnpm run typespec:openapi",
     "start": "node dist/index.js",
     "dev": "ts-node src/index.ts",
     "prepare": "tsc",
@@ -48,7 +48,10 @@
     "format": "prettier --write .",
     "check:lint": "eslint . --ext .ts",
     "check:format": "prettier --check .",
-    "checks": "npm run check:lint && npm run check:format"
+    "check:types": "tsc --noEmit",
+    "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",
+    "test:coverage": "jest --coverage",
+    "audit": "pnpm audit"
   },
   "dependencies": {
     "@apidevtools/swagger-parser": "^10.1.1",

lib/core/package.json

@@ -35,12 +35,14 @@
     "build": "tsc -p .",
     "watch": "tsc -p . --watch",
     "typespec": "tsp compile lib/main.tsp",
-    "prepare": "npm run build",
+    "prepare": "pnpm run build",
     "lint": "eslint . --fix",
     "format": "prettier --write . && tsp format lib",
     "check:lint": "eslint",
     "check:format": "prettier --check . && tsp format lib --check",
-    "checks": "npm run check:lint && npm run check:format"
+    "check:types": "tsc --noEmit",
+    "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",
+    "audit": "pnpm audit"
   },
   "keywords": [
     "typespec",

lib/python-sdk/Makefile

@@ -0,0 +1,28 @@
+RUNTIME_PREFIX := poetry run
+.PHONY: install format lint test build check-format check-lint check-types checks
+
+install:
+	poetry install
+
+format:
+	$(RUNTIME_PREFIX) black .
+
+lint:
+	$(RUNTIME_PREFIX) ruff check .
+
+test:
+	$(RUNTIME_PREFIX) pytest
+
+build:
+	poetry build
+
+check-format:
+	$(RUNTIME_PREFIX) black . --check
+
+check-lint:
+	$(RUNTIME_PREFIX) ruff check .
+
+check-types:
+	$(RUNTIME_PREFIX) mypy .
+
+checks: check-format check-lint check-types

lib/ts-sdk/package.json

@@ -67,7 +67,9 @@
     "format": "prettier --write .",
     "check:lint": "eslint . --ext .ts",
     "check:format": "prettier --check .",
-    "checks": "pnpm check:lint && pnpm check:format",
+    "check:types": "tsc --noEmit",
+    "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",
+    "audit": "pnpm audit",
     "typespec": "tsp compile lib/main.tsp",
     "example:list": "tsx examples/list-opportunities.ts",
     "example:get": "tsx examples/get-opportunity.ts",

website/package.json

@@ -24,12 +24,13 @@
     "check:format": "prettier --check .",
     "check:astro": "astro check",
     "check:spelling": "cspell .",
-    "checks": "pnpm check:lint && pnpm check:format && pnpm check:astro && pnpm check:spelling",
+    "check:types": "tsc --noEmit",
+    "checks": "pnpm check:lint && pnpm check:format && pnpm check:types && pnpm check:astro && pnpm check:spelling",
     "audit:moderate": "pnpm audit --audit-level=moderate",
     "audit:high": "pnpm audit --audit-level=high",
     "audit:critical": "pnpm audit --audit-level=critical",
     "validate:schemas": "tsx src/scripts/validate-schemas.ts",
-    "test": "vitest"
+    "test": "vitest run"
   },
   "dependencies": {
     "@astrojs/react": "^4.4.2",