Merged
Conversation
Skips ajv warnings because there are compatibility issues with eslint
Fixing the CVE for ajv causes some breaking changes with eslint
Contributor
|
🚀 Website Preview Deployed! Preview your changes at: https://cg-pr-526.billy-daly.workers.dev This preview will be automatically deleted when the PR is closed. |
jcrichlake
approved these changes
Feb 23, 2026
Contributor
|
🗑️ Preview Cleaned Up The preview for this PR has been automatically deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the CLI to vitest to align with other projects in this codebase and resolve a lingering CI failure that was blocking #522
Changes proposed
jestwithvitestin dependenciesvitestsyntaxcatalog:for vitest dependencyajvwarning because of a conflict witheslintContext for reviewers
Testing instructions
There aren't really any additional checks for us to test manually. The main check is the CI which runs both the tests and
pnpm audit.Reason for this change
The move to vitest was long overdue and resolved a few other warnings that we'd get every time we installed all of the dev dependencies in
lib/cli/. But mostly this was necessary to resolve this persistent CLI failure that stemmed from a mismatch between ESModule and CJS -- two different module formats for JavaScript.TL;DR Jest is an outdated testing framework that uses an old JavaScript module format that was causing extra headaches. Switching to vitest aligns CLI with the rest of the codebase and fixes the blocking CI failures.
Notes
devDependenciesthis shouldn't require a patch release on any of the libraries we modified.Additional information