Skip to content

Commit

Permalink
Write more in comment
Browse files Browse the repository at this point in the history
  • Loading branch information
adzialocha committed Nov 16, 2024
1 parent c05884b commit a5feabb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion rhio-blobs/src/s3_file.rs
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ impl S3File {
}

pub fn reader(&self) -> HttpAdapter {
// @TODO: This currently requires the bucket to be _public_.
// @TODO(adz): This currently requires the bucket to be _public_. We can sign the HTTP
// request to fullfil the S3 authentication API or use the S3 API straight away.
// https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-authenticating-requests.html
let url = self.bucket.url();
HttpAdapter::new(url::Url::from_str(&format!("{url}/{}", &self.path)).unwrap())
}
Expand Down

0 comments on commit a5feabb

Please sign in to comment.