Skip to content

[104] add prometheus metrics #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 13, 2025
Merged

Conversation

ktatarnikovhiro
Copy link
Collaborator

@ktatarnikovhiro ktatarnikovhiro commented Dec 10, 2024

  • happy flow metrics added
  • error metrics are still not easy to incorporate. I will consider that after integration tests are done

@ktatarnikovhiro ktatarnikovhiro linked an issue Dec 10, 2024 that may be closed by this pull request
Copy link

ellipsis-dev bot commented Dec 10, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev or contact us.

Copy link
Collaborator

@sandreae sandreae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe one change is required in the metrics reporting when receiving NATS messages.

Copy link

@Shockedshodan Shockedshodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

@ktatarnikovhiro ktatarnikovhiro merged commit b1b2f95 into main Jan 13, 2025
7 checks passed
@ktatarnikovhiro ktatarnikovhiro deleted the 104-add-prometheus-metrics branch January 13, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prometheus metrics
4 participants