Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests s3 #114

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Integration tests s3 #114

merged 2 commits into from
Jan 20, 2025

Conversation

ktatarnikovhiro
Copy link
Collaborator

@ktatarnikovhiro ktatarnikovhiro commented Jan 20, 2025

This pull request introduces several changes and additions to the rhio project, as summarized below:

Cargo.toml

  1. Added s3-server as a new workspace member.
  2. Added dependencies:
    • s3-server (path)
    • s3s-fs (version 0.10.0)
    • s3s (version 0.10.0)
    • hyper-util (version 0.1.10) with features server, http1, http2, and tokio

rhio/Cargo.toml

  1. Added s3-server, s3s, and url to the workspace.

rhio/src/config.rs

  1. Added protocol field to NodeConfig.
  2. Introduced ProtocolConfig struct with poll_interval_seconds and resync_interval_seconds.
  3. Added Hash trait for several structs including NodeConfig, KnownNode, ProtocolConfig, PublishConfig, SubscribeConfig, RemoteS3Bucket, LocalNatsSubject, and RemoteNatsSubject.

rhio/src/context_builder.rs

  1. Modified SyncConfiguration to include protocol configuration from NodeConfig.

rhio/src/tests/blob_replication.rs

  1. Added a new test file for end-to-end blob replication tests.
  2. Implemented a test test_e2e_blob_replication to verify blob replication between source and target.

rhio/src/tests/configuration.rs

  1. Introduced TwoClusterBlobSetup struct for two-cluster blob storage system setup.
  2. Added create_two_node_blob_setup function to create a blob storage setup.
  3. Added helper functions new_s3_server, generate_s3_config, and configure_blob_subscription.

rhio/src/tests/mod.rs

  1. Added blob_replication module.

s3-server/Cargo.toml

  1. Added a new Cargo.toml for s3-server.

s3-server/src/lib.rs

  1. Added a new library file for s3-server.

These changes primarily add support for a new s3-server component and enhance the existing configuration and testing infrastructure to support blob replication functionality.

Copy link

ellipsis-dev bot commented Jan 20, 2025

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev or contact us.

Copy link

@Shockedshodan Shockedshodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktatarnikovhiro ktatarnikovhiro merged commit b6a8617 into main Jan 20, 2025
7 checks passed
@ktatarnikovhiro ktatarnikovhiro deleted the integration-tests-s3 branch January 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants