使用 JFXListView 显示实例列表 #5174
Merged
使用 JFXListView 显示实例列表 #5174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the game instance list display to use JFXListView instead of custom Control-based implementations. The changes modernize the UI architecture by replacing custom skin-based controls with standard JavaFX ListView cells.
Changes:
- Introduces
GameListPopupMenuusing JFXListView for displaying game instances in a popup - Replaces custom skin classes (
GameListItemSkin,GameItemSkin) withGameListCellfor ListView-based rendering - Refactors
GameItemfrom a Control to a plain data class with lazy property initialization - Adds
ToolbarListPageSkin2as a new skin implementation for list pages using JFXListView
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| GameListPopupMenu.java | New popup menu component using JFXListView to display game instances |
| GameListCell.java | New ListCell implementation replacing GameListItemSkin for rendering game list items |
| ToolbarListPageSkin2.java | New skin base class for toolbar list pages using JFXListView |
| GameListPage.java | Simplified game list loading logic, removed ToggleGroup usage, switched to static nested class |
| GameListItem.java | Refactored to extend GameItem, removed custom skin, simplified selection binding |
| GameItem.java | Converted from Control to data class with lazy property initialization and updated copyright year |
| MainPage.java | Updated to use new GameListPopupMenu instead of PopupMenu |
| WeakListenerHolder.java | Added clear() method for cleanup |
| GameListItemSkin.java | Deleted - functionality moved to GameListCell |
| GameItemSkin.java | Deleted - no longer needed as GameItem is not a Control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/GameListPage.java
Outdated
Show resolved
Hide resolved
Comment on lines
211
to
243
| private void preparePopupMenu(GameListItem item) { | ||
| this.getListView().getProperties().put(POPUP_ITEM_KEY, item); | ||
| } | ||
|
|
||
| private static Runnable getAction(ListView<GameListItem> listView, Consumer<GameListItem> action) { | ||
| return () -> { | ||
| if (listView.getProperties().get(POPUP_ITEM_KEY) instanceof GameListItem item) { | ||
| action.accept(item); | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| private static JFXPopup getPopup(ListView<GameListItem> listView) { | ||
| return (JFXPopup) listView.getProperties().computeIfAbsent(GameListCell.class.getName() + ".popup", k -> { | ||
| PopupMenu menu = new PopupMenu(); | ||
| JFXPopup popup = new JFXPopup(menu); | ||
|
|
||
| menu.getContent().setAll( | ||
| new IconedMenuItem(SVG.ROCKET_LAUNCH, i18n("version.launch.test"), getAction(listView, GameListItem::testGame), popup), | ||
| new IconedMenuItem(SVG.SCRIPT, i18n("version.launch_script"), getAction(listView, GameListItem::generateLaunchScript), popup), | ||
| new MenuSeparator(), | ||
| new IconedMenuItem(SVG.SETTINGS, i18n("version.manage.manage"), getAction(listView, GameListItem::modifyGameSettings), popup), | ||
| new MenuSeparator(), | ||
| new IconedMenuItem(SVG.EDIT, i18n("version.manage.rename"), getAction(listView, GameListItem::rename), popup), | ||
| new IconedMenuItem(SVG.FOLDER_COPY, i18n("version.manage.duplicate"), getAction(listView, GameListItem::duplicate), popup), | ||
| new IconedMenuItem(SVG.DELETE, i18n("version.manage.remove"), getAction(listView, GameListItem::remove), popup), | ||
| new IconedMenuItem(SVG.OUTPUT, i18n("modpack.export"), getAction(listView, GameListItem::export), popup), | ||
| new MenuSeparator(), | ||
| new IconedMenuItem(SVG.FOLDER_OPEN, i18n("folder.game"), getAction(listView, GameListItem::browse), popup)); | ||
|
|
||
| popup.setOnHidden(event -> listView.getProperties().remove(POPUP_ITEM_KEY)); | ||
| return popup; | ||
| }); |
There was a problem hiding this comment.
The getPopup method stores the current GameListItem in the ListView's properties, but this state is only cleared when the popup is hidden. If the popup is shown again before being hidden, or if the reference changes, there could be issues with stale item references. Consider also clearing the item reference in preparePopupMenu or ensuring proper cleanup in all code paths.
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/GameListPopupMenu.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.