feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 #5260

deepsleep-v3 · 2026-01-19T09:17:29Z

“Switch Working Directory”（暂只有en_US翻译）

先讲一个小故事，我电脑之前C:空间太少，重装系统了，资料被format了，我转移了我的MC资料到我的U盘。但！我没转移我的hmcl.json，所以，VersionSetting也无了。到最后，我启动MC的时候，资源包、模组都丢了，一看，没开“各版本隔离”，于是，deepsleep-v3像是下定了某种决心，他马上就fork了HMCL-dev/HMCL，并且clone到他的电脑……

所以我就把这个弹窗做出来了，由于个人精力原因，暂只翻译了en_US、zh-Hant、zh-CN。原理是HMCLGameLauncher生成options.txt的函数（generateOptionsTxt）里getRunDirectory()时先检测repository是否instanceof HMCLGameRepository，再创建变量，再检测：

Files.exists(Path.of(HMCLRepository.getVersionRoot(version.getId()).toString(), "resourcepacks")) ||
Files.exists(Path.of(HMCLRepository.getVersionRoot(version.getId()).toString(), "saves")) ||
Files.exists(Path.of(HMCLRepository.getVersionRoot(version.getId()).toString(), "mods")) ||
Files.exists(Path.of(HMCLRepository.getVersionRoot(version.getId()).toString(), "shaderpacks")) || 
Files.exists(Path.of(HMCLRepository.getVersionRoot(version.getId()).toString(), "crash-report"))

（代码写的有点烂，请见谅😳）
2. 修复文档的一些语法错误
起因是我在准备提交37a03fc时，发现JavaDoc写了个：

// org.jackhuang.hmcl.game.HMCLGameRepository，getLocalVersionSetting(String) → VersionSetting的文档。
/**
* Get the version setting for version id.
*
* @param id version id
* @return corresponding version setting, null if the version has no its own version setting.
*/

（原句）
限定词(determiner)和物主代词(possessive pronoun)不能一起用！
就顺手修了，修成了：

// org.jackhuang.hmcl.game.HMCLGameRepository，getLocalVersionSetting(String) → VersionSetting的文档。
/**
* Get the version setting for version id.
*
* @param id version id
* @return corresponding version setting, null if the version does not have its own version setting.
*/

谁叫我爱MC，爱HMCL呢~

Added a confirmation dialog when unexpected folders (resourcepacks, saves, mods, shaderpacks, crash-report) are detected in the version root, prompting the user to switch to 'Isolated' mode. Updated I18N.properties with new dialog strings for this feature.

Replaces manual string concatenation with Path.of() using varargs for directory checks in the ROOT_FOLDER case, improving code readability and reliability.

Added logic to process the user's selection from the working directory switch alert dialog, updating the game directory type or returning the appropriate directory based on the chosen button.

## 问题描述在后台线程中直接调用JavaFX的Alert组件会导致`IllegalStateException: Not on FX application thread`异常，影响程序稳定性。 ## 修改内容 - 将原有的直接Alert调用包装在`Platform.runLater()`中，确保UI操作在JavaFX应用程序线程执行 - 使用`CompletableFuture`在JavaFX线程和非JavaFX线程之间传递用户选择结果 - 保持原有的业务逻辑和对话框选项不变 - 添加异常处理，在对话框异常时使用默认值继续执行 ## 技术细节 1. 创建`CompletableFuture<ButtonData>`用于接收用户选择 2. 在`Platform.runLater()`中： - 创建Confirmation类型的Alert对话框 - 设置三个按钮选项：是、否、仅本次启动 - 使用`showAndWait()`等待用户响应 - 将用户选择的按钮数据传递给CompletableFuture 3. 在后台线程中使用`future.get()`阻塞等待用户选择 4. 根据按钮数据执行相应的目录设置逻辑 ## 影响范围 - 修复启动器在非JavaFX线程中询问工作目录切换的问题 - 确保线程安全的同时保持原有功能不变 - 提升程序在多线程环境下的稳定性 ## 测试要点 ✅ 在后台线程中调用此代码段能正常显示对话框 ✅ 对话框的三个按钮功能与之前一致 ✅ 异常情况下能使用默认值继续执行 ✅ 不会出现线程阻塞或死锁问题 ## 关联问题修复了在多线程环境下可能导致的UI崩溃问题

burningtnt

粗略的（在没有真正看代码逻辑的情况下）看了一眼，我认为你这里有一堆问题需要改动。

此外，简体中文和繁体中文的翻译是必须的。如果你不能熟练使用繁体中文，可使用机器翻译提供初稿，并注明需要社区成员在 PR 合并前检查润色。

HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameLauncher.java

HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameRepository.java

HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameLauncher.java

deepsleep-v3 · 2026-01-19T11:44:18Z

粗略的（在没有真正看代码逻辑的情况下）看了一眼，我认为你这里有一堆问题需要改动。

此外，简体中文和繁体中文的翻译是必须的。如果你不能熟练使用繁体中文，可使用机器翻译提供初稿，并注明需要社区成员在 PR 合并前检查润色。

√ 已解决

3gf8jv4dv

说实话，这个弹窗不是太美观，也不适配深色模式。可否改成下面列出的 PR 中更新的形式？

HMCL/src/main/resources/assets/lang/I18N.properties

HMCL/src/main/resources/assets/lang/I18N_ja.properties

HMCL/src/main/resources/assets/lang/I18N_zh.properties

HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

burningtnt

显然你关闭了根本没解决的问题。此外，如果你不了解相关语言，请不要翻译非完全支持语言（比如日语）

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

update

deepsleep-v3 added 8 commits January 18, 2026 15:59

Refactor path construction in ROOT_FOLDER check

92ea64e

Replaces manual string concatenation with Path.of() using varargs for directory checks in the ROOT_FOLDER case, improving code readability and reliability.

Handle user response in working directory switch alert

00bf5a2

Added logic to process the user's selection from the working directory switch alert dialog, updating the game directory type or returning the appropriate directory based on the chosen button.

fix(JavaDoc): 修复了一些文档中的语法错误和文件格式应当保持大写

37a03fc

Moved "Switch Working Directory".

bcd4a87

fix(bug)：填补了未填充的大括号

e238c11

fix：格式

f0329a3

deepsleep-v3 closed this Jan 19, 2026

deepsleep-v3 reopened this Jan 19, 2026

修复了额外导入的同包下内容

5becbaf

deepsleep-v3 changed the title ~~为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误~~ feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 Jan 19, 2026

burningtnt suggested changes Jan 19, 2026

View reviewed changes

Wulian233 reviewed Jan 19, 2026

View reviewed changes

HMCL/src/main/java/org/jackhuang/hmcl/game/HMCLGameLauncher.java Outdated Show resolved Hide resolved

deepsleep-v3 added 2 commits January 19, 2026 19:13

fix：修复了本人发现的问题及PR#5260所提到的一些批判

612aa8f

add+fix: 修正了格式，并添加亚洲语言（zh-Hant、zh-CN、ja-JP）的翻译。

1d52a58

deepsleep-v3 requested a review from burningtnt January 19, 2026 11:44

UPDATE

95d2876

3gf8jv4dv reviewed Jan 19, 2026

View reviewed changes

burningtnt suggested changes Jan 19, 2026

View reviewed changes

deepsleep-v3 and others added 9 commits January 20, 2026 08:06

Update HMCL/src/main/resources/assets/lang/I18N.properties

cd090e7

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N.properties

5d2ff48

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N.properties

9c5df2f

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

1619480

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh.properties

84b1969

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

e35dc82

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Update HMCL/src/main/resources/assets/lang/I18N_zh_CN.properties

31cc0c4

Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>

Merge pull request #1 from CiiLu/deepsleep-v3/main

9c5440d

update

fallback ja_JP

c6e33a9

deepsleep-v3 added 5 commits January 20, 2026 10:26

Merge branch 'main' of https://github.com/deepsleep-v3/HMCL

6bab585

Merge branch 'HMCL-dev:main' into main

294299d

fixed format

d69676b

Merge branch 'main' of https://github.com/deepsleep-v3/HMCL

06c0cc1

一些语法错误（Part Ⅰ）

9fea525

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 #5260

feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 #5260

deepsleep-v3 commented Jan 19, 2026 •

edited

Loading

Uh oh!

burningtnt left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepsleep-v3 commented Jan 19, 2026

Uh oh!

3gf8jv4dv left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

burningtnt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 #5260

Are you sure you want to change the base?

feat+fix：为HMCL启动时添加“Switch Working Directory”并修复文档的一些语法错误 #5260

Conversation

deepsleep-v3 commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

burningtnt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deepsleep-v3 commented Jan 19, 2026

Uh oh!

3gf8jv4dv left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

burningtnt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deepsleep-v3 commented Jan 19, 2026 •

edited

Loading

3gf8jv4dv left a comment •

edited

Loading