Skip to content

Commit

Permalink
Remove examples/lassie
Browse files Browse the repository at this point in the history
After discussion with Heiko Becker.
  • Loading branch information
mn200 committed Jan 5, 2024
1 parent 7818249 commit dc68c31
Show file tree
Hide file tree
Showing 382 changed files with 0 additions and 58,433 deletions.
7 changes: 0 additions & 7 deletions examples/lassie/Holmakefile

This file was deleted.

12 changes: 0 additions & 12 deletions examples/lassie/examples/Holmakefile

This file was deleted.

44 changes: 0 additions & 44 deletions examples/lassie/examples/arithTacticsLib.sml

This file was deleted.

280 changes: 0 additions & 280 deletions examples/lassie/examples/caseStudy1EuclidScript.sml

This file was deleted.

Loading

5 comments on commit dc68c31

@binghe
Copy link
Member

@binghe binghe commented on dc68c31 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI test failure shows that there are duplicated exported theorems in examples/logic/foltypesScript.sml.

I think it's possible that previously in src/parallel_builds/core/Holmakefile not only "lassie" but also some (if not all) example folders after it were also disabled by the leading "#" character (if the ending backslash is interpreted by unconditionally appending the next line). Now, examples/logic finally got a chance to run, and the issue is exposed ...

@binghe
Copy link
Member

@binghe binghe commented on dc68c31 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If doing line-commenting (by a leading #) in a line of Holmakefile with backslash at the end of that line actually means commenting also the next line (or next lines if they also end with backslash), perhaps this behavior should be considered problematic and fixed in the code handling Holmakefile.

@mn200
Copy link
Member Author

@mn200 mn200 commented on dc68c31 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! I will check to see what traditional make does in this situation.

@mn200
Copy link
Member Author

@mn200 mn200 commented on dc68c31 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference suggests that what Holmake is doing is consistent with established practice.

@binghe
Copy link
Member

@binghe binghe commented on dc68c31 Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference suggests that what Holmake is doing is consistent with established practice.

I see... So Holmake behaves correctly.

Please sign in to comment.