Fix DB.find slowness when searching with regexes #1271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the DB.find search regexp was compiled into a DFA every time an entry in the database was checked. This compilation step has now been moved so this only happens once per search.
…ds30/HOL into bug/fix-db-find-slowness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edit I messed this branch up I'm closing this and opening a different one with the commits cherry picked on
Currently in draft mode since I think it needs everyone to run the smart configure tool to rebuild regexpMatch.sml, and I'm not too sure how to get around that
After adding basic regex support to DB.find (#1246), DB.find is unusably slow, which I didn't realise since I didn't have many theories built when testing.
Previously, the DB.find search regexp was compiled into a DFA every time an entry in the database was checked. This compilation step has now been moved so this only happens once per search.
Also, added
.and*operators for any character and zero-or-more matches respectively: