Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otknl build #1338

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix otknl build #1338

merged 1 commit into from
Nov 13, 2024

Conversation

binghe
Copy link
Member

@binghe binghe commented Nov 13, 2024

Hi,

This should fix the otknl build. There's only one small shift of goals in the generated "hol4-assums.art" causing failure when building src/boss/prove_base_assumsTheory. The previous th62 is now th60 (th62 |-> th60; th60 |-> th61; th61 |-> th62), very local changes, perhaps due to modifications in listTheory.

Let's see how the CI goes.

--Chun

@binghe
Copy link
Member Author

binghe commented Nov 13, 2024

The way to fix such issues is to evaluate expressions like el 60 goals |> concl at the broken theorem, and check if the output matches the theorem statements in near comments (that I added just for this purpose), and if not the same, the current proof is not for the current goal (but another goal in different place). Only in rare cases we need to add whole new proofs to handle more goals (currently there are 96 of them).

@mn200 mn200 mentioned this pull request Nov 13, 2024
@digama0 digama0 mentioned this pull request Nov 13, 2024
@mn200
Copy link
Member

mn200 commented Nov 13, 2024

Thanks for getting this done!

@mn200 mn200 merged commit 5518574 into HOL-Theorem-Prover:develop Nov 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants