Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define SHA-256 (part of the SHA-2 standard) and translate it for cv compute #1358

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Define SHA-256 (part of the SHA-2 standard) and translate it for cv compute #1358

merged 9 commits into from
Dec 10, 2024

Conversation

xrchz
Copy link
Member

@xrchz xrchz commented Nov 30, 2024

As with Keccak (SHA-3), this is one of the cryptographic algorithms used in the Ethereum virtual machine.

xrchz added 6 commits November 27, 2024 23:10
@xrchz
sha2: fix some typos
c1edb60
@xrchz
Fix pad_message and prove cheat
3f15952
@xrchz
Prove initial_schedule_loop_pre
220cfa1
@xrchz
Define SHA-256
f73067a 
Make it take nums instead of bools to start with.

There is still something wrong with byte order or something here
(comparing against test vectors).
@xrchz
Attempt to debug some endianness issues in sha2
12f48ee
@xrchz
Fix bug, two SHA-256 tests now pass
3aa3fab
@xrchz xrchz requested a review from mn200 November 30, 2024 13:26
mn200
mn200 requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mn200 mn200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put this directory into the build sequence (by adjusting src/parallel_builds/core/Holmakefile)

@xrchz
Copy link
Member Author

xrchz commented Dec 3, 2024

Please put this directory into the build sequence (by adjusting src/parallel_builds/core/Holmakefile)

This is done

@mn200
Copy link
Member

mn200 commented Dec 9, 2024

It's not building because your Holmakefile needs an INCLUDES line pointing at the directory with cv_transLib etc. (The reason in turn is that build is doing everything in parallel so needs accurate directory dependency info within post-boss directories.)

@xrchz
Copy link
Member Author

xrchz commented Dec 9, 2024

Thanks I've added that Holmakefile now.

@xrchz xrchz merged commit 8140422 into develop Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mn200 mn200 mn200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xrchz @mn200