Simplify enkf_clm_5.F90
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commented code, b) use a modified cime_comp_mod:cime_run() instead of copying large parts of code, c) modified cime_comp_mod:cime_run() to take the TSMP timestep as an additonal argument to stop the main loop and added the private statement back, and d) remove some leftover debug output.
This was referenced Jun 19, 2024
jjokella
force-pushed
the
simplify_enkf_clm_5
branch
from
617de08 to
b0bc416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
clm_advancecontains a large portion of duplicate code from the CIME'scime_runfunction. The goal of this PR is to remove this duplicate code and instead add a call tocime_run.In order to add this change, the following has been done
tsmp/clm5_0: updated to align with CIME tagcime5.6.47tsmp/clm5_0: changes in CIME-patch files are added in order to makecime_runcallable with the number of time steps specified in the TSMP-PDAF interfaceenkf_clm_5.F90: duplicate code is removed andcime_runcalled instead