Update of documents on "HSF Affiliated Projects and Software" and related Guidelines #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme-a-stewart
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks @eduardo-rodrigues! I generally approve, but I have a wording suggestion for the versioning piece.
graeme-a-stewart
approved these changes
Oct 28, 2024
|
pre-commit failure is a false positive, not relevant to this PR |
|
Thanks for the quick reaction. Feel free to merge when OKed since I won't be able to later this week (cf. my private message to you). |
|
Yep, LGTM! Plus Valentin just fixed the spelling false alarm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #1595 and #1599 to address trivial fixes for typos and to modify slightly the text as per community feedback.