DT-6564 Navigator journey end modal

[partisaani]

Proposed Changes

Adds a Navigator journey end signaling modal

journey-end.mp4

Pull Request Check List

• A reasonable set of unit tests is included
• Console does not show new warnings/errors
• Changes are documented or they are self explanatory
• This pull request does not have any merge conflicts
• All existing tests pass in CI build

Review

• Read and verify the code changes. I suggest a commit-by-commit review
• Test the functionality by running the UI locally with all popular browsers available in your platform
• Check that the implementation matches the design, when such one is defined in a Jira issue
• Merge the pull request

[vesameskanen]

Mostly clean code and good refactoring, but handling of currentLeg concept probably requires further effort.

[vesameskanen]

I am not totally against this but why to pass first and last leg as a prop? Indexing the array is not that expensive or complicated.

Note that these legs are not consistently used in NaviContainer or NavicardContainer.

[partisaani]

To centralize the deduction logic instead of having identical pieces of logic in multiple components. Thus, useRealtimeLegs becomes responsible for correctness of data from there on out.

[Antiik91]

We are currently using our icons insvg-sprite.hsl.svgand svg-sprite.default.svg We should move these icons there. Using a same key would render different images based on what instance is running.(And none if there is no corresponding icon, but may throw an error, not sure)

I highly suspect we would want images for other instances as well, even though they are yet to be designed.

[partisaani]

I'd say this is out of scope of this PR

[Antiik91]

There is a bug. where user cannot pan the map or zoom in/out.

[partisaani]

There is a bug. where user cannot pan the map or zoom in/out.

Inspecting this at the moment

[vesameskanen]

NaviContainer indexes leg array instead of using lastLeg

[partisaani]

Gah! Will fix.