Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6589 & DT-6587: Navigator shows notifications for expired legs and we should disallow close for canceled routes #5189

Merged
merged 2 commits into from
Dec 9, 2024
Merged

DT-6589 & DT-6587: Navigator shows notifications for expired legs and we should disallow close for canceled routes #5189

merged 2 commits into from
Dec 9, 2024

Conversation

Antiik91
Copy link
Member

@Antiik91 Antiik91 commented Dec 9, 2024

Proposed Changes

  • Navigator uses time to determine when the transitLegState notification should expire
  • Hide close button in notification when there is journey breaking notification (cancelled, no route available..)
  • Made the divider line thinner in main card as designed.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@vesameskanen vesameskanen merged commit c37ff25 into v3 Dec 9, 2024
6 checks passed
@vesameskanen vesameskanen deleted the DT-6589 branch December 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Antiik91 @vesameskanen