Various navigation bug fixes and improvements #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vesameskanen
commented
Dec 16, 2024
vesameskanen
commented
- Estimate transfer progress by user location only after transfer has started. Before that, use elapsed time.
- Transit leg state card now updates. Updating happens also when user is waiting at the stop.
- Transit leg state card shows route name and realtime in green
- Transit leg state card expires when it should
- Other cards do not expire because of comparison of undefined and time
- Warning logic about absence of realtime works as designed (considers trip start, not leg start time)
- Compute transfer proceeding only when transfer walk has started - Get transfer duration from unmodified leg.duration, not from start and end times which change by realtime
- Card updates - Card does not reopen if user closes it
No realtime state occurs when transit has departed from its first stop more than 2 minutes ago.
partisaani
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.