Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6573 : #5203

Merged
merged 2 commits into from
Dec 16, 2024
Merged

DT-6573 : #5203

merged 2 commits into from
Dec 16, 2024

Conversation

Antiik91
Copy link
Member

Proposed Changes

  • Do not fetch itinerarypage topics when in navigator mode
  • update topics in navigator so that only relevant vehicles are shown
  • add wait img back

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@Antiik91
do not fetch itinerarypage topics when in navigator mode
cad43d9 
update topics in navigator so that only relevant vehicles are shown

add wait img back
partisaani
partisaani approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@partisaani partisaani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vesameskanen vesameskanen merged commit 0ebbe7b into v3 Dec 16, 2024
6 checks passed
@vesameskanen vesameskanen deleted the DT-6573 branch December 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partisaani partisaani partisaani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Antiik91 @partisaani @vesameskanen