Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-6476 Memoized planar leg calculation #5215

Merged
merged 1 commit into from
Dec 27, 2024
Merged

DT-6476 Memoized planar leg calculation #5215

merged 1 commit into from
Dec 27, 2024

Conversation

partisaani
Copy link
Contributor

Proposed Changes

  • Optimizes costly planar leg calculation by using useMemo hook with initialLegs as dependency array

Pay attention to the logged "Converting initial legs..." line in the following images:

Before:
image
After:
image

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@partisaani partisaani self-assigned this Dec 27, 2024
@vesameskanen vesameskanen merged commit 00f5859 into v3 Dec 27, 2024
6 checks passed
@vesameskanen vesameskanen deleted the DT-6476_patch-4 branch December 27, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesameskanen vesameskanen vesameskanen approved these changes

@Antiik91 Antiik91 Awaiting requested review from Antiik91

Assignees

@partisaani partisaani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@partisaani @vesameskanen