Skip to content

Proper rerouting logic and misc improvements #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Dec 30, 2024
Merged

Proper rerouting logic and misc improvements #5216

merged 16 commits into from
Dec 30, 2024

Conversation

vesameskanen
Copy link
Member

New itinerary search works now as follows:

  • During transit leg, search from next stop after a decent threshold
  • During walking, search from user location if available, otherwise from the leg end
  • During waiting/before journey start, search from next leg start
  • Use actual geolocation, not 'POS' path, which seems to be slow/unreliable when geolocation is already enabled

Other fixes:

  • Alert generation and rendering code refactored
  • Alert content now updates by newer versions
  • Alerts can be closed and they won't reappear
  • Static schedule warning is not shown before 2 minutes to first departure
  • Wait leg focusing works correctly
  • Semantic fix: current leg is not set before itinerary starts

vesameskanen and others added 16 commits December 27, 2024 15:00
@vesameskanen
fix: allow alerts to update
7909d0a
@vesameskanen
chore: refactor navi alerts
12dcc5e 
- remove unncessary div and style
- don't repeat code or pass static content as prop
- don't render many alerts about triggering new itinerary search
- better names
@vesameskanen
chore: render search alert only when needed
c5b3b26
@vesameskanen
fix: parameter order
9a938a5
@vesameskanen
feat: support OTP stop type in locationToUri
9536cb4
@vesameskanen
feat: advanced rerouting
7dbd36c 
- Search from next stop if in transit leg
- Use existing position if available, instead of geolocator wrapper
@vesameskanen
fix: initial little bugs in new implementation
9136032
@vesameskanen
fix: rerouting from waitleg or before the journey
9b1deb2
@vesameskanen
fix: current leg should be undefined before itinerary starts
372c325
@vesameskanen
fix: do not show transit realtime absence notifier too early
cc5cdad 
If realtime is missing from a transit at its first stop, we should
ignore it until there is only 2 minutes to the departure.
@vesameskanen
fix: intermediate stop details are needed for rerouting
7a6a88a
@vesameskanen
fix: stop merge which produces valid location
090d26a
@vesameskanen
chore: rename
4bfe0cd
@vesameskanen
fix: buggy alert identification
2cfca57
@vesameskanen
fix: focus without geolocation during a wait leg
b8ac997 
Navi focused on last leg if current leg was undefined
@vesameskanen
chore: reset temporary test constants
3960390
partisaani
partisaani approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@partisaani partisaani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@partisaani partisaani merged commit fe48e46 into v3 Dec 30, 2024
6 checks passed
@partisaani partisaani deleted the reroute-from-stop branch December 30, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@partisaani partisaani partisaani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vesameskanen @partisaani