DT-6691 Non-scrollable navigator bottom sheet #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partisaani
commented
Feb 6, 2025
| const pathParts = match.location.pathname.split('/'); | ||
| const pagePrefix = pathParts?.length > 1 ? pathParts[1] : undefined; | ||
|
|
||
| // pass these to map according to bottom sheet placement | ||
| const [bottomPadding, setBottomPadding] = useState(getMiddlePosition()); | ||
|
|
||
| const onScroll = e => { | ||
| if (e.target.className === 'drawer-container') { | ||
| if (e.target.className === 'drawer-container' && e.target.scrollTop) { |
There was a problem hiding this comment.
This check prevents a weird initial onScroll run from setting the scrollTop as 0
vesameskanen
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Looks otherwise OK, but I found some regressions:
- Offset for map controls has changed slightly. OpenStreetMap copyright notice and map measure line are often partially or totally hidden under bottom sheet
- Go to itinerary detail view. Reload the page. Bottom sheet is minimized like in navi view (itinerary hidden) and map controls are rendered in the middle of the map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pull Request Check List
Review