-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event Tests #122
Event Tests #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not giving a formal review yet because this is still in progress, but here's two small things for now. General heuristic for tests is look at coverage and see what isn't covered - and make sure you're covering those edge cases.
sponsor: "Example sponsor", | ||
eventType: "OTHER", | ||
points: 0, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: Use satisfies to verify correctness
expect(response).toHaveProperty("error"); | ||
}); | ||
|
||
it("cannot be accessed by staff", async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need to test for every level - just test the level below what is expect (staff for admin only, attendee for staff only, etc)
Will contain comprehensive tests for the events service